bootstrap.js ➔ ??? - Code Metrics - okaufmann/laravel-web-money-manager-ex - Measure and Improve Code Quality continuously with Scrutinizer

bootstrap.js ➔ ??? A
last analyzed 2017-10-18 00:22 UTC

↳ Parent: resources/assets/js/bootstrap.js

Complexity

Conditions	1
Paths	32

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	1
nc	32
nop	0
dl	0
loc	59
rs	9.597
c	2
b	0
f	1

3 Functions

Rating	Name	Size	Complexity
A	bootstrap.js ➔ ... ➔ $(ꞌtextarea, inputꞌ).keyup	3	2
A	bootstrap.js ➔ ... ➔ $(ꞌtextarea, inputꞌ).keydown	7	4
B	bootstrap.js ➔ ... ➔ ???	16	5

How to fix Long Method

/**
 * We'll load the axios HTTP library which allows us to easily issue requests
 * to our Laravel back-end. This library automatically handles sending the
 * CSRF token as a header based on the value of the "XSRF" token cookie.
 */

window.axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';

/**
 * Sett global authorization headers for js libraries
 */
window.axios.defaults.headers.common['Authorization'] = "Bearer " + Laravel.apiToken;

$.ajaxSetup({
    beforeSend: function (xhr) {
        xhr.setRequestHeader("Authorization", "Bearer " + Laravel.apiToken);

    }
});
kendo.jQuery.ajaxSetup({

    beforeSend: function (xhr) {
        xhr.setRequestHeader("Authorization", "Bearer " + Laravel.apiToken);

    }
});

/**
 * Next we will register the CSRF Token as a common header with Axios so that
 * all outgoing HTTP requests automatically have it attached. This is just
 * a simple convenience so we don't have to attach every token manually.
 */

let token = document.head.querySelector('meta[name="csrf-token"]');

if (token) {
    window.axios.defaults.headers.common['X-CSRF-TOKEN'] = token.content;
} else {
    console.error('CSRF token not found: https://laravel.com/docs/csrf#csrf-x-csrf-token');
}

/**
 * Echo exposes an expressive API for subscribing to channels and listening
 * for events that are broadcast by Laravel. Echo and event broadcasting
 * allows your team to easily build robust real-time web applications.
 */

// window.Echo = new Echo({
//     broadcaster: 'pusher',
//     key: 'your-pusher-key'
// });

// Material Buttons
$(() => {
    window['mmex'] = window['mmex'] || {};
    window['mmex']['momentLocal'] = (date) => {
        if (!date || _.isEmpty(date)) {

            return moment();
        }

        let m = moment(date);
        if (m.isValid()) {
            return m;
        }
        m = moment(date, "DD.MM.YYYY");
        if (m.isValid()) {
            return m;
        }

        throw new Error("No supported date format found for ", date);
    };

    $.material.init();

    autosize($('textarea'));

    $("[autofocus]").focus();

    $(".common-dateinput").each((index, elm) => {
        let val = $(elm).val();
        let date = mmex.momentLocal(val).toDate();

        console.log("set date ", date, " out of ", val);

        new kendo.ui.DateInput($(elm), {

            value: val ? date : new Date()
        });
    });

    $(".common-datepicker").each((index, elm) => {
        let val = $(elm).val();
        let date = mmex.momentLocal(val).toDate();

        console.log("set date ", date, " out of ", val);

        new kendo.ui.DatePicker($(elm), {

            value: val ? date : new Date()
        });
    });

    $(".common-dropdown-list").each((index, elm) => {
        new kendo.ui.DropDownList($(elm), {

            filter: "startswith",
        });
    });

    $('textarea, input').keyup(function (e) {
        if (e.which == 17) isCtrl = false;
if (a > 0)
    b = 42;
    }).keydown(function (e) {
        if (e.which == 17) isCtrl = true;
if (a > 0)
    b = 42;
        if (e.which == 13 && isCtrl === true) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
            $(this).closest('form').submit();
            return false;
        }
    });
});

1			/**
2			* We'll load the axios HTTP library which allows us to easily issue requests
3			* to our Laravel back-end. This library automatically handles sending the
4			* CSRF token as a header based on the value of the "XSRF" token cookie.
5			*/
6
7			window.axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';
8
9			/**
10			* Sett global authorization headers for js libraries
11			*/
12			window.axios.defaults.headers.common['Authorization'] = "Bearer " + Laravel.apiToken;
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `Laravel` seems to be never declared. If this is a global, consider adding a `/** global: Laravel */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
13			$.ajaxSetup({
14			beforeSend: function (xhr) {
15			xhr.setRequestHeader("Authorization", "Bearer " + Laravel.apiToken);
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `Laravel` seems to be never declared. If this is a global, consider adding a `/** global: Laravel */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
16			}
17			});
18			kendo.jQuery.ajaxSetup({
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `kendo` seems to be never declared. If this is a global, consider adding a `/** global: kendo */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
19			beforeSend: function (xhr) {
20			xhr.setRequestHeader("Authorization", "Bearer " + Laravel.apiToken);
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `Laravel` seems to be never declared. If this is a global, consider adding a `/** global: Laravel */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
21			}
22			});
23
24			/**
25			* Next we will register the CSRF Token as a common header with Axios so that
26			* all outgoing HTTP requests automatically have it attached. This is just
27			* a simple convenience so we don't have to attach every token manually.
28			*/
29
30			let token = document.head.querySelector('meta[name="csrf-token"]');
31
32			if (token) {
33			window.axios.defaults.headers.common['X-CSRF-TOKEN'] = token.content;
34			} else {
35			console.error('CSRF token not found: https://laravel.com/docs/csrf#csrf-x-csrf-token');
36			}
37
38			/**
39			* Echo exposes an expressive API for subscribing to channels and listening
40			* for events that are broadcast by Laravel. Echo and event broadcasting
41			* allows your team to easily build robust real-time web applications.
42			*/
43
44			// window.Echo = new Echo({
45			// broadcaster: 'pusher',
46			// key: 'your-pusher-key'
47			// });
48
49			// Material Buttons
50			$(() => {
51			window['mmex'] = window['mmex'] \|\| {};
52			window['mmex']['momentLocal'] = (date) => {
53			if (!date \|\| _.isEmpty(date)) {
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `_` seems to be never declared. If this is a global, consider adding a `/** global: _ */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
54			return moment();
55			}
56
57			let m = moment(date);
58			if (m.isValid()) {
59			return m;
60			}
61			m = moment(date, "DD.MM.YYYY");
62			if (m.isValid()) {
63			return m;
64			}
65
66			throw new Error("No supported date format found for ", date);
67			};
68
69			$.material.init();
70
71			autosize($('textarea'));
72
73			$("[autofocus]").focus();
74
75			$(".common-dateinput").each((index, elm) => {
76			let val = $(elm).val();
77			let date = mmex.momentLocal(val).toDate();
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `mmex` seems to be never declared. If this is a global, consider adding a `/** global: mmex */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
78			console.log("set date ", date, " out of ", val);
			0 ignored issues – show Debugging Code introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
79			new kendo.ui.DateInput($(elm), {
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `kendo` seems to be never declared. If this is a global, consider adding a `/** global: kendo */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Unused Code Best Practice introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The object created with `new kendo.ui.DateInput($...false),ListBuffer()))})` is not used but discarded. Consider invoking another function instead of a constructor if you are doing this purely for side effects. Loading history...
80			value: val ? date : new Date()
81			});
82			});
83
84			$(".common-datepicker").each((index, elm) => {
85			let val = $(elm).val();
86			let date = mmex.momentLocal(val).toDate();
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `mmex` seems to be never declared. If this is a global, consider adding a `/** global: mmex */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
87			console.log("set date ", date, " out of ", val);
			0 ignored issues – show Debugging Code introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
88			new kendo.ui.DatePicker($(elm), {
			0 ignored issues – show Unused Code Best Practice introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The object created with `new kendo.ui.DatePicker(...false),ListBuffer()))})` is not used but discarded. Consider invoking another function instead of a constructor if you are doing this purely for side effects. Loading history... Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `kendo` seems to be never declared. If this is a global, consider adding a `/** global: kendo */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
89			value: val ? date : new Date()
90			});
91			});
92
93			$(".common-dropdown-list").each((index, elm) => {
94			new kendo.ui.DropDownList($(elm), {
			0 ignored issues – show Unused Code Best Practice introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The object created with `new kendo.ui.DropDownLis...teralNode(startswith)})` is not used but discarded. Consider invoking another function instead of a constructor if you are doing this purely for side effects. Loading history... Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `kendo` seems to be never declared. If this is a global, consider adding a `/** global: kendo */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
95			filter: "startswith",
96			});
97			});
98
99			$('textarea, input').keyup(function (e) {
100			if (e.which == 17) isCtrl = false;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `isCtrl` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.isCtrl`. Loading history...
101			}).keydown(function (e) {
102			if (e.which == 17) isCtrl = true;
			0 ignored issues – show Coding Style Best Practice introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history... Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `isCtrl` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.isCtrl`. Loading history...
103			if (e.which == 13 && isCtrl === true) {
			0 ignored issues – show Bug introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report The variable `isCtrl` does not seem to be initialized in case `e.which == 17` on line `102` is `false`. Are you sure this can never be the case? Loading history... Complexity Best Practice introduced 2017-09-27 23:18 UTC by Report Bug Copy Issue Report There is no return statement if `e.which == 13 && isCtrl === true` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
104			$(this).closest('form').submit();
105			return false;
106			}
107			});
108			});

okaufmann / laravel-web-money-manager-ex

GitHub Access Token became invalid

bootstrap.js ➔ ??? A last analyzed 2017-10-18 00:22 UTC

Complexity

Size

Duplication

Importance

3 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

bootstrap.js ➔ ??? A
last analyzed 2017-10-18 00:22 UTC